From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Landley <rob@landley.net>
Subject: Re: [PATCH] LogFS take three
Date: Sat, 19 May 2007 02:15:33 -0400
Message-ID: <200705190215.36334.rob@landley.net>
References: <20070515151919.GA32510@lazybastard.org> <20070515133759.9ee434a2.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: =?iso-8859-1?q?J=F6rn_Engel?= <joern@lazybastard.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, Albert Cahalan <acahalan@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Greg KH <greg@kroah.com>, Ingo Oeser <ioe-lkml@rameria.de>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1762225AbXESGR1@vger.kernel.org>
In-Reply-To: <20070515133759.9ee434a2.akpm@linux-foundation.org>
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tuesday 15 May 2007 4:37 pm, Andrew Morton wrote:

> > +static inline struct logfs_super *LOGFS_SUPER(struct super_block *=
sb)
> > +{
> > +	return sb->s_fs_info;
> > +}
> > +
> > +static inline struct logfs_inode *LOGFS_INODE(struct inode *inode)
> > +{
> > +	return container_of(inode, struct logfs_inode, vfs_inode);
> > +}
>=20
> Do these need to be uppercase?

I'm trying to keep it clear in my head...

When do you need to say __always_inline and when can you get away with =
just=20
saying "static inline"?

(I'm attempting to write documentation on a topic I don't understand.  =
Best=20
way to learn it, I've found...)

> > +=A0=A0=A0=A0=A0buf =3D kmap(page);
> > +=A0=A0=A0=A0=A0ret =3D logfs_write_buf(inode, index, buf);
> > +=A0=A0=A0=A0=A0kunmap(page);
>
> kmap() is lame. =A0The preferred approach would be to pass the page* =
down to
> the lower layers and to use kmap_atomic() at the lowest possible poin=
t.

Um, would I read about this in DMA-mapping.txt or cachetlb.txt?  (I don=
't=20
think it's fujitsu/frv/mmu-layout.txt)

Rob