From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: Review status (Re: [PATCH] LogFS take three) Date: Wed, 23 May 2007 14:58:41 +0200 Message-ID: <20070523125840.GC24738@lazybastard.org> References: <20070515151919.GA32510@lazybastard.org> <20070515152149.GB32059@lazybastard.org> <20070517160308.GA26643@2ka.mipt.ru> <20070517171017.GB15676@lazybastard.org> <20070520173049.GA20907@2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, Albert Cahalan , Thomas Gleixner , Jan Engelhardt , Pekka Enberg , Greg KH , Ingo Oeser To: Evgeniy Polyakov Return-path: Received: from lazybastard.de ([212.112.238.170]:41511 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755043AbXEWNDN (ORCPT ); Wed, 23 May 2007 09:03:13 -0400 Content-Disposition: inline In-Reply-To: <20070520173049.GA20907@2ka.mipt.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, 20 May 2007 21:30:52 +0400, Evgeniy Polyakov wrote: >=20 > In that case segment size must be more than 32 bits, or below > transformation will not be correct? Must it? If segment size is just 20bit then the filesystem may only be 52bit. Or 51bit when using signed values. > segsize is long, but should be u64 I think. It could be s32 as well. > static void fixup_from_wbuf(struct super_block *sb, struct logfs_area > *area, void *read, u64 ofs, size_t readlen) >=20 > u32 read_start =3D ofs & (super->s_segsize - 1); > u32 read_end =3D read_start + readlen; >=20 > And this can overflow, since readlen is size_t. Theoretically yes. Practically readlen is bounded to sb->blocksize plu= s one header. I'll start worrying about that when blocksize approaches 32bit limit. > > If anyone can find similar bugs, the bounty is a beer or non-alcoho= lic > > beverage of choice. :) >=20 > Stop kiling your kidneys, your health and promote such antisocial sty= le > of life, start drinking vodka instead. I'm just a German. Forgive me if I drink lesser beverages. J=C3=B6rn --=20 Eighty percent of success is showing up. -- Woody Allen - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html