linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: David Chinner <dgc@sgi.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add procfs tunable to enable immediate panic when there are busy inodes after umount
Date: Wed, 30 May 2007 07:47:45 -0400	[thread overview]
Message-ID: <20070530074745.15b8355b.jlayton@redhat.com> (raw)
In-Reply-To: <20070530002857.GW85884050@sgi.com>

On Wed, 30 May 2007 10:28:57 +1000
David Chinner <dgc@sgi.com> wrote:

> On Tue, May 29, 2007 at 11:40:42AM -0400, Jeff Layton wrote:
> > After spending quite a bit of time tracking down a "VFS: busy inodes
> > after unmount" problem, it occurs to me that it would be nice to be
> > able to force a panic when that occurs. While an oops message alone is
> > not generally helpful for tracking down this sort of problem,
> > collecting and analyzing a coredump when this occurs can be.
> 
> Agreed - we've found that we've had roughly 50% success in finding
> the cause of these problems from crash dumps triggered immediately
> like this vs ~0% from a crash that occurred some time later.
> 
> Given that this problem will always result in a crash of the kernel
> at some random time in the future, why don't we just make this error
> an unconditional panic on get the crash over and done with?
> 

Perhaps that's the best course of action. Then again, there can be a
long time between the problem and crash (weeks even). For someone who
can't collect a coredump, it might be preferable to not immediately
crash the box and allow them to try to reboot it at a convenient time.
That was my reasoning for adding the procfs tunable.

Either way, if the machine doesn't crash immediately, I'd like to see a
different error message here. The current one is confusing to users.
They see it and figure "my box didn't crash in 5 mins, so everything
must be OK!"

-- 
Jeff Layton <jlayton@redhat.com>

      reply	other threads:[~2007-05-30 11:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29 15:40 [PATCH] add procfs tunable to enable immediate panic when there are busy inodes after umount Jeff Layton
2007-05-29 19:38 ` Alexey Dobriyan
2007-05-29 19:46   ` Jeff Layton
2007-05-30  0:28 ` David Chinner
2007-05-30 11:47   ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530074745.15b8355b.jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=dgc@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).