From: "J. Bruce Fields" <bfields@fieldses.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] AFS: Implement file locking [try #2]
Date: Wed, 30 May 2007 14:03:09 -0400 [thread overview]
Message-ID: <20070530180309.GG7736@fieldses.org> (raw)
In-Reply-To: <32087.1180514132@redhat.com>
On Wed, May 30, 2007 at 09:35:32AM +0100, David Howells wrote:
> J. Bruce Fields <bfields@fieldses.org> wrote:
>
> > --without having tried to understand how they're actually used, these
> > data structures (like the pending_locks and granted_locks lists) seem to
> > duplicate stuff that's already kept in fs/locks.c. Is there a reason
> > they're required?
>
> Yes. I need to get the server lock first, before going to the VFS locking
> routines.
That doesn't really answer the question. The NFS client has similar
requirements, but it doesn't have to duplicate the per-inode lists of
granted locks, for example.
> The VFS routines as they stand aren't particularly useful, and they
> permit things that AFS doesn't support (such as lock upgrading).
Sure. But handling those things is just a matter of checking for a few
special cases and making sure they're rejected before calling the posix
routines.
--b.
next prev parent reply other threads:[~2007-05-30 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 14:54 [PATCH] AFS: Implement file locking [try #2] David Howells
2007-05-29 21:57 ` J. Bruce Fields
2007-05-30 8:35 ` David Howells
2007-05-30 18:03 ` J. Bruce Fields [this message]
2007-05-31 9:41 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530180309.GG7736@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).