From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 12/41] fs: introduce write_begin, write_end, and perform_write aops Date: Wed, 30 May 2007 21:52:31 -0700 Message-ID: <20070530215231.468e7f26.akpm@linux-foundation.org> References: <20070524052844.860329000@suse.de> <20070524053155.065366000@linux.local0.net> <20070530213035.d7b6e3e0.akpm@linux-foundation.org> <20070531044327.GD20107@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh , Linux Memory Management To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([207.189.120.13]:42026 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757807AbXEaExP (ORCPT ); Thu, 31 May 2007 00:53:15 -0400 In-Reply-To: <20070531044327.GD20107@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 31 May 2007 06:43:27 +0200 Nick Piggin wrote: > > INFO: lockdep is turned off. > > Code: 49 c0 89 44 24 0c 89 7c 24 08 89 5c 24 04 c7 04 24 ac 2a 49 c0 e8 e9 ff f7 ff e8 b4 21 f6 ff 8b 4d f0 e9 a6 fe ff ff 0f 0b eb fe <0f> 0b eb fe 8d 74 26 00 0f 0b eb fe 0f 0b eb fe 90 8d b4 26 00 > > EIP: [] __block_prepare_write+0x348/0x360 SS:ESP 0068:de89fd60 > > > > > > That's > > > > BUG_ON(to > PAGE_CACHE_SIZE); > > > Thanks. Hmm, sorry I didn't test splice much. Does this fix it? Don't know - I shelved the patches. Given the great pile of build errors, I think we need the next rev.