From: Andrew Morton <akpm@linux-foundation.org>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
David Chinner <dgc@sgi.com>, Anton Altaparmakov <aia21@cam.ac.uk>,
Al Viro <viro@ftp.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH resend] introduce I_SYNC
Date: Thu, 31 May 2007 15:46:48 -0700 [thread overview]
Message-ID: <20070531154648.b21d9fe2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070531142535.GA25236@lazybastard.org>
On Thu, 31 May 2007 16:25:35 +0200
Jörn Engel <joern@lazybastard.org> wrote:
> On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote:
> >
> > If we're going to do this then please let's get some exhaustive commentary
> > in there so that others have a chance of understanding these flags without
> > having to do the amount of reverse-engineering which you've been put through.
>
> Done. Found and fixed some bugs in the process. By now I feal
> reasonable certain that the patch fixes more than it breaks.
>
>
> --
> Good warriors cause others to come to them and do not go to others.
> -- Sun Tzu
>
> Introduce I_SYNC.
>
> I_LOCK was used for several unrelated purposes, which caused deadlock
> situations in certain filesystems as a side effect. One of the purposes
> now uses the new I_SYNC bit.
Do we know what those deadlocks were? It's a bit of a mystery patch otherwise.
Put yourself in the position of random-distro-engineer wondering "should I
backport this?".
> Also document the various bits and change their order from historical to
> logical.
What a nice comment you added ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-05-31 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 17:01 [PATCH resend] introduce I_SYNC Jörn Engel
2007-05-16 17:15 ` Andrew Morton
2007-05-16 17:47 ` Jörn Engel
2007-05-31 14:25 ` Jörn Engel
2007-05-31 18:06 ` Dave Kleikamp
2007-05-31 22:46 ` Andrew Morton [this message]
2007-06-01 12:00 ` Jörn Engel
2007-06-01 8:59 ` Anton Altaparmakov
2007-06-01 11:56 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531154648.b21d9fe2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aia21@cam.ac.uk \
--cc=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).