From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH resend] introduce I_SYNC Date: Thu, 31 May 2007 15:46:48 -0700 Message-ID: <20070531154648.b21d9fe2.akpm@linux-foundation.org> References: <20070516170110.GC8113@lazybastard.org> <20070516101535.94e44b3b.akpm@linux-foundation.org> <20070531142535.GA25236@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Kleikamp , David Chinner , Anton Altaparmakov , Al Viro , Christoph Hellwig To: =?ISO-8859-1?Q?J=F6rn?= Engel Return-path: Received: from smtp1.linux-foundation.org ([207.189.120.13]:51148 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbXEaWsC convert rfc822-to-8bit (ORCPT ); Thu, 31 May 2007 18:48:02 -0400 In-Reply-To: <20070531142535.GA25236@lazybastard.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 31 May 2007 16:25:35 +0200 J=F6rn Engel wrote: > On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote: > > > > If we're going to do this then please let's get some exhaustive com= mentary > > in there so that others have a chance of understanding these flags = without > > having to do the amount of reverse-engineering which you've been pu= t through. >=20 > Done. Found and fixed some bugs in the process. By now I feal > reasonable certain that the patch fixes more than it breaks. >=20 >=20 > --=20 > Good warriors cause others to come to them and do not go to others. > -- Sun Tzu >=20 > Introduce I_SYNC. >=20 > I_LOCK was used for several unrelated purposes, which caused deadlock > situations in certain filesystems as a side effect. One of the purpo= ses > now uses the new I_SYNC bit. Do we know what those deadlocks were? It's a bit of a mystery patch ot= herwise. Put yourself in the position of random-distro-engineer wondering "shoul= d I backport this?". > Also document the various bits and change their order from historical= to > logical. What a nice comment you added ;) - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html