From: Christoph Hellwig <hch@infradead.org>
To: Steve French <smfrench@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs-client@lists.samba.org
Subject: Re: [PATCH] support larger cifs network reads
Date: Tue, 5 Jun 2007 10:30:17 +0100 [thread overview]
Message-ID: <20070605093017.GA30288@infradead.org> (raw)
In-Reply-To: <524f69650705311608l5433dedj4ec4f903e9af3ce4@mail.gmail.com>
On Thu, May 31, 2007 at 06:08:23PM -0500, Steve French wrote:
> With Samba 3.0.26pre it is now possible for a cifs client (one which
> supports the newest Unix/Posix cifs extensions) to request up to
> almost 8MB at a time on a cifs read request.
>
> A patch for the cifs client to support larger reads follows. In this
> patch, using very large reads is not the default behavior, since it
> would require larger buffer allocations for the large cifs request
> buffers, but in the future when cifs can demultiplex reads to a page
> list in the cifs_demultiplex_thread (without having to copy to a large
> temporary buffer) this will be even more useful.
Increasing this now doesn't make any sense - slab won't be able to
create a 8MB cache on most architectures, and even if it could the
wasted memory would be enormous. Once you actually support
scatter/gather allocations an increase is fine.
prev parent reply other threads:[~2007-06-05 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 23:08 [PATCH] support larger cifs network reads Steve French
2007-06-05 9:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605093017.GA30288@infradead.org \
--to=hch@infradead.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).