From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] support larger cifs network reads Date: Tue, 5 Jun 2007 10:30:17 +0100 Message-ID: <20070605093017.GA30288@infradead.org> References: <524f69650705311608l5433dedj4ec4f903e9af3ce4@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org To: Steve French Return-path: Content-Disposition: inline In-Reply-To: <524f69650705311608l5433dedj4ec4f903e9af3ce4@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 31, 2007 at 06:08:23PM -0500, Steve French wrote: > With Samba 3.0.26pre it is now possible for a cifs client (one which > supports the newest Unix/Posix cifs extensions) to request up to > almost 8MB at a time on a cifs read request. > > A patch for the cifs client to support larger reads follows. In this > patch, using very large reads is not the default behavior, since it > would require larger buffer allocations for the large cifs request > buffers, but in the future when cifs can demultiplex reads to a page > list in the cifs_demultiplex_thread (without having to copy to a large > temporary buffer) this will be even more useful. Increasing this now doesn't make any sense - slab won't be able to create a 8MB cache on most architectures, and even if it could the wasted memory would be enormous. Once you actually support scatter/gather allocations an increase is fine.