linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: "Florian D." <flockmock@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS
Date: Fri, 15 Jun 2007 16:51:40 -0400	[thread overview]
Message-ID: <20070615205140.GV2061@think.oraclecorp.com> (raw)
In-Reply-To: <4672FA8C.50309@gmail.com>

On Fri, Jun 15, 2007 at 10:46:04PM +0200, Florian D. wrote:
> Chris Mason wrote:
> >> # umount /mnt/temp/
> >>
> >> [  457.980372] ------------[ cut here ]------------
> >> [  457.980377] kernel BUG at fs/buffer.c:2644!
> > 
> > Whoops.  Please try this:

[ bad patch ]

> sorry, with the patch applied:
> 
> [  147.475077] BUG: at
> /home/florian/system/btrfs_test/btrfs-0.2/disk-io.c:534

Well, apparently I get get the silly stuff wrong an infinite number of
times.  Sorry, lets try again:

diff -r 38b36aaaa731 disk-io.c
--- a/disk-io.c	Fri Jun 15 13:50:20 2007 -0400
+++ b/disk-io.c	Fri Jun 15 16:52:38 2007 -0400
@@ -541,6 +541,8 @@ int write_ctree_super(struct btrfs_trans
 	else
 		ret = submit_bh(WRITE, bh);
 	if (ret == -EOPNOTSUPP) {
+		get_bh(bh);
+		lock_buffer(bh);
 		set_buffer_uptodate(bh);
 		root->fs_info->do_barriers = 0;
 		ret = submit_bh(WRITE, bh);

  reply	other threads:[~2007-06-15 20:55 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12 16:10 [ANNOUNCE] Btrfs: a copy on write, snapshotting FS Chris Mason
2007-06-12 19:53 ` Mike Snitzer
2007-06-12 20:14   ` Chris Mason
2007-06-13  3:08     ` Christoph Hellwig
2007-06-13 10:17       ` Chris Mason
2007-06-13  3:46 ` John Stoffel
2007-06-13 10:35   ` Chris Mason
2007-06-13 14:00     ` John Stoffel
2007-06-13 14:54       ` Chris Mason
2007-06-13 16:12         ` John Stoffel
2007-06-13 16:34           ` Chris Mason
2007-06-13 16:25         ` Grzegorz Kulewski
2007-06-14 18:20   ` Chuck Lever
2007-06-14 18:48     ` Chris Mason
2007-06-15 17:17       ` Chuck Lever
2007-06-14 18:29 ` Florian D.
2007-06-14 19:13   ` Chris Mason
2007-06-15 19:08     ` Florian D.
2007-06-15 19:11       ` Chris Mason
2007-06-15 20:46         ` Florian D.
2007-06-15 20:51           ` Chris Mason [this message]
2007-06-15 22:03             ` Florian D.
2007-06-16  0:54               ` Chris Mason
2007-06-16  9:31                 ` Florian D.
2007-06-18 14:29                   ` Chris Mason
2007-06-18 14:41 ` Chris Mason
2007-06-18 17:37 ` Vladislav Bolkhovitin
2007-06-18 20:08   ` John Stoffel
2007-06-19  9:11   ` Pádraig Brady
2007-06-19 10:01     ` Vladislav Bolkhovitin
2007-06-19 18:20       ` david
2007-06-20  8:41         ` Vladislav Bolkhovitin
2007-06-19 12:04     ` Chris Mason
2007-06-19 14:00       ` Vladislav Bolkhovitin
2007-06-19 18:24       ` david
2007-06-19 18:28       ` Philipp Matthias Hahn
2007-06-20  8:44         ` Vladislav Bolkhovitin
2007-06-20  9:18           ` Ph. Marek
  -- strict thread matches above, loose matches on Subject: below --
2007-06-13  5:45 Albert Cahalan
2007-06-13 12:00 ` Chris Mason
2007-06-13 16:14   ` Albert Cahalan
2007-06-13 16:57     ` Chris Mason
2007-06-14  6:59       ` Albert Cahalan
2007-06-14 12:30         ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070615205140.GV2061@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=flockmock@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).