From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 02/26] ext3: remove extra IS_RDONLY() check
Date: Sat, 23 Jun 2007 08:36:58 +0100
Message-ID: <20070623073658.GB27954@infradead.org>
References: <20070622200303.82D9CC3A@kernel> <20070622200305.F066FCB4@kernel>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, hch@infradead.org,
	viro@ftp.linux.org.uk
To: Dave Hansen <haveblue@us.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:57526 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751681AbXFWHhB (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jun 2007 03:37:01 -0400
Content-Disposition: inline
In-Reply-To: <20070622200305.F066FCB4@kernel>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Fri, Jun 22, 2007 at 01:03:05PM -0700, Dave Hansen wrote:
> 
> ext3_change_inode_journal_flag() is only called from one
> location: ext3_ioctl(EXT3_IOC_SETFLAGS).  That ioctl
> case already has a IS_RDONLY() call in it so this one
> is superfluous.

Ok, and stands nicely on it's own.