From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 04/26] filesystem helpers for custom 'struct file's Date: Sat, 23 Jun 2007 08:38:42 +0100 Message-ID: <20070623073842.GD27954@infradead.org> References: <20070622200303.82D9CC3A@kernel> <20070622200308.A4245108@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk To: Dave Hansen Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:57539 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbXFWHio (ORCPT ); Sat, 23 Jun 2007 03:38:44 -0400 Content-Disposition: inline In-Reply-To: <20070622200308.A4245108@kernel> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 22, 2007 at 01:03:08PM -0700, Dave Hansen wrote: > > Christoph H. says this stands on its own and can go in before the > rest of the r/o bind mount set. > > --- > > Some filesystems forego the vfs and may_open() and create their > own 'struct file's. > > This patch creates a couple of helper functions which can be > used by these filesystems, and will provide a unified place > which the r/o bind mount code may patch. > > Also, rename two existing, static-scope init_file() to less > generic names. Looks good. Again this should go in ASAP after 2.6.23 independent of the more complicated bits because it's a nice cleanup. In the end get_empty_filp should go away as an exported symbol. Note that we've grown more instances of the crap you're fixing here, e.g. fs/anon_inode.c