From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/26] r/o bind mounts: stub functions Date: Sat, 23 Jun 2007 08:39:50 +0100 Message-ID: <20070623073950.GE27954@infradead.org> References: <20070622200303.82D9CC3A@kernel> <20070622200309.985982F5@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk To: Dave Hansen Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:34667 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875AbXFWHjx (ORCPT ); Sat, 23 Jun 2007 03:39:53 -0400 Content-Disposition: inline In-Reply-To: <20070622200309.985982F5@kernel> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 22, 2007 at 01:03:09PM -0700, Dave Hansen wrote: > > This patch adds two function mnt_want_write() and > mnt_drop_write(). These are used like a lock pair around > and fs operations that might cause a write to the filesystem. > > Before these can become useful, we must first cover each > place in the VFS where writes are performed with a > want/drop pair. When that is complete, we can actually > introduce code that will safely check the counts before > allowing r/w<->r/o transitions to occur. Ok, > > Note that we put the linux/fs.h #include as far down in > mount.h as possible. This is to keep the mount.h->fs.h-> > sched.h->mount.h include dependency from biting us. except for this. Please just move __mnt_is_readonly out of line or make it a macro, but we surely don't want to include fs.h in mount.h