From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 07/26] r/o bind mounts: elevate write count for some ioctls Date: Sat, 23 Jun 2007 08:42:15 +0100 Message-ID: <20070623074215.GG27954@infradead.org> References: <20070622200303.82D9CC3A@kernel> <20070622200312.56BC4845@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk To: Dave Hansen Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:34678 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594AbXFWHmR (ORCPT ); Sat, 23 Jun 2007 03:42:17 -0400 Content-Disposition: inline In-Reply-To: <20070622200312.56BC4845@kernel> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 22, 2007 at 01:03:12PM -0700, Dave Hansen wrote: > > Some ioctl()s can cause writes to the filesystem. Take > these, and make them use mnt_want/drop_write() instead. > > We need to pass the filp one layer deeper in XFS, but > somebody _just_ pulled it out in February because nobody > was using it, so I don't feel guilty for adding it back. Could have been me :) Would be nicer to just pass down the vfsmount instead of the file in XFS, but it shouldn't really matter in the end.