Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 25 Jun 2007 08:37:29 -0700 Dave Hansen <hansendc@us.ibm.com> wrote:

> On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote:
> > > On Fri, 22 Jun 2007 13:03:08 -0700 Dave Hansen <haveblue@us.ibm.com> wrote:
> > > Christoph H. says this stands on its own and can go in before the
> > > rest of the r/o bind mount set.  
> > > 
> > > ---
> > > 
> > > Some filesystems forego the vfs and may_open() and create their
> > > own 'struct file's.
> > > 
> > > This patch creates a couple of helper functions which can be
> > > used by these filesystems, and will provide a unified place
> > > which the r/o bind mount code may patch.
> > > 
> > > Also, rename two existing, static-scope init_file() to less
> > > generic names.
> > 
> > the sysfs changes are no longer applicable here due to pending changes in
> > Greg's tree.
> > 
> > The net/socket.c change is a mystery.  My version of sock_attach_fd()
> > doesn't look like yours.
> 
> Should I rebase them on top of -mm, or a just current -rc?
> 

Weren't they already against current -rc?  I really am mystified about
where your net/socket.c cam from, although I didn't search super-hard (I
was offline at the time).

Normally against current -rc, but the pending sysfs changes do mean that it
perhaps would be better if you were to runtime test it at least against
Greg's tree.