From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 04/26] filesystem helpers for custom 'struct file's Date: Mon, 25 Jun 2007 10:25:05 -0700 Message-ID: <20070625102505.660e7849.akpm@linux-foundation.org> References: <20070622200303.82D9CC3A@kernel> <20070622200308.A4245108@kernel> <20070623095220.76dba6bc.akpm@linux-foundation.org> <1182785849.26162.93.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Dave Hansen , linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk To: Dave Hansen Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:42205 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbXFYR02 (ORCPT ); Mon, 25 Jun 2007 13:26:28 -0400 In-Reply-To: <1182785849.26162.93.camel@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 25 Jun 2007 08:37:29 -0700 Dave Hansen wrote: > On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > > On Fri, 22 Jun 2007 13:03:08 -0700 Dave Hansen wrote: > > > Christoph H. says this stands on its own and can go in before the > > > rest of the r/o bind mount set. > > > > > > --- > > > > > > Some filesystems forego the vfs and may_open() and create their > > > own 'struct file's. > > > > > > This patch creates a couple of helper functions which can be > > > used by these filesystems, and will provide a unified place > > > which the r/o bind mount code may patch. > > > > > > Also, rename two existing, static-scope init_file() to less > > > generic names. > > > > the sysfs changes are no longer applicable here due to pending changes in > > Greg's tree. > > > > The net/socket.c change is a mystery. My version of sock_attach_fd() > > doesn't look like yours. > > Should I rebase them on top of -mm, or a just current -rc? > Weren't they already against current -rc? I really am mystified about where your net/socket.c cam from, although I didn't search super-hard (I was offline at the time). Normally against current -rc, but the pending sysfs changes do mean that it perhaps would be better if you were to runtime test it at least against Greg's tree.