From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/6] locks: provide a file lease method enabling cluster-coherent leases Date: Sat, 30 Jun 2007 10:26:07 +0100 Message-ID: <20070630092607.GE22050@infradead.org> References: <6e0beaf3e950494a6903571f0b5c9b61fc7bf650.1183143819.git.bfields@citi.umich.edu> <59343fe9a0b0bdb9c39ed217185b9c0d6c7d8dae.1183143819.git.bfields@citi.umich.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, "J. Bruce Fields" To: "J. Bruce Fields" Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:47353 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754542AbXF3J0K (ORCPT ); Sat, 30 Jun 2007 05:26:10 -0400 Content-Disposition: inline In-Reply-To: <59343fe9a0b0bdb9c39ed217185b9c0d6c7d8dae.1183143819.git.bfields@citi.umich.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 29, 2007 at 03:21:26PM -0400, J. Bruce Fields wrote: > From: J. Bruce Fields > > Currently leases are only kept locally, so there's no way for a distributed > filesystem to enforce them against multiple clients. We're particularly > interested in the case of nfsd exporting a cluster filesystem, in which > case nfsd needs cluster-coherent leases in order to implement delegations > correctly. Looks good but should be moved second to last in the patch series, with the last one beeing implementing setleast for gfs. Also see my comment to the nfs patch about the default semantics for not implementing the method.