From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 14/26] elevate write count for file_update_time()
Date: Sat, 30 Jun 2007 10:38:12 +0100
Message-ID: <20070630093812.GH22354@infradead.org>
References: <20070622200303.82D9CC3A@kernel> <20070622200321.1D813C8A@kernel> <20070623074636.GK27954@infradead.org> <1182796328.1387.11.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>, akpm@osdl.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk
To: Dave Hansen <haveblue@us.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:46944 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753836AbXF3JiQ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 30 Jun 2007 05:38:16 -0400
Content-Disposition: inline
In-Reply-To: <1182796328.1387.11.camel@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Jun 25, 2007 at 11:32:08AM -0700, Dave Hansen wrote:
> How does this look?
> 
> -       if (IS_RDONLY(inode))
> +       /*
> +        * Ideally, we want to guarantee that 'f_vfsmnt'
> +        * is non-NULL here.  But, NFS exports need to
> +        * be fixed up before we can do that.  So, check
> +        * it for now. - Dave Hansen
> +        */
> +       if (file->f_vfsmnt)
> +               err = mnt_want_write(file->f_vfsmnt);
> +       if (err)
>                 return;

Looks okay.  Unfortunately we've grown some more callers of dentry_open
with a NULL vfsmount in the meantime (*grasp* reiserfs xattr mess *grasp*)