From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs_mknod/create()
Date: Sat, 30 Jun 2007 10:39:01 +0100
Message-ID: <20070630093901.GI22354@infradead.org>
References: <20070622200303.82D9CC3A@kernel> <20070622200332.DCCD1884@kernel> <20070623075103.GS27954@infradead.org> <1182784792.26162.86.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	Dave Hansen <haveblue@us.ibm.com>, akpm@osdl.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk
To: Dave Hansen <hansendc@us.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:46956 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751679AbXF3JjD (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 30 Jun 2007 05:39:03 -0400
Content-Disposition: inline
In-Reply-To: <1182784792.26162.86.camel@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Jun 25, 2007 at 08:19:52AM -0700, Dave Hansen wrote:
> > Should we just take the calls outside the switch statement? 
> 
> Yeah, that's much better.  I assume we don't care whether we're getting
> -EROFS or -EPERM/-EINVAL for the S_IFDIR and default cases?

We need to keep the exact error returns, so you'll have to add some
special case checks before the r/o check.  It's probably still cleaner,
though.