From: Andreas Dilger <adilger@clusterfs.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
nfsv4@linux-nfs.org
Subject: Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update
Date: Tue, 3 Jul 2007 15:41:31 -0600 [thread overview]
Message-ID: <20070703214131.GH6578@schatzie.adilger.int> (raw)
In-Reply-To: <4689F17C.7050304@linux.vnet.ibm.com>
On Jul 03, 2007 12:19 +0530, Aneesh Kumar K.V wrote:
> Mingming Cao wrote:
> >Index: linux-2.6.22-rc4/fs/ext4/super.c
> >===================================================================
> >--- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-13
> >17:19:11.000000000 -0700
> >+++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-13 17:24:45.000000000 -0700
> >@@ -2846,8 +2846,8 @@ out:
> > i_size_write(inode, off+len-towrite);
> > EXT4_I(inode)->i_disksize = inode->i_size;
> > }
> >- inode->i_version++;
> > inode->i_mtime = inode->i_ctime = CURRENT_TIME;
> >+ inode->i_version = 1;
> > ext4_mark_inode_dirty(handle, inode);
> > mutex_unlock(&inode->i_mutex);
> > return len - towrite;
>
>
> Is this correct ? . Why do we set the qutoa file inodes version to 1
> during write ?
Hmm, I thought we had previously fixed this?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-07-03 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:37 [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update Mingming Cao
2007-07-03 6:49 ` Aneesh Kumar K.V
2007-07-03 21:41 ` Andreas Dilger [this message]
2007-07-10 23:31 ` Andrew Morton
2007-07-11 8:47 ` Christoph Hellwig
2007-07-11 11:52 ` Andreas Dilger
2007-07-11 12:02 ` Christoph Hellwig
2007-07-11 11:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703214131.GH6578@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).