From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 4/6] locks: fix locks.c lease symbol exports Date: Wed, 4 Jul 2007 17:42:55 -0400 Message-ID: <20070704214255.GC26764@fieldses.org> References: <6e0beaf3e950494a6903571f0b5c9b61fc7bf650.1183143819.git.bfields@citi.umich.edu> <20070630092345.GC22050@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail.fieldses.org ([66.93.2.214]:45192 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755564AbXGDVm7 (ORCPT ); Wed, 4 Jul 2007 17:42:59 -0400 Content-Disposition: inline In-Reply-To: <20070630092345.GC22050@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Jun 30, 2007 at 10:23:45AM +0100, Christoph Hellwig wrote: > On Fri, Jun 29, 2007 at 03:21:28PM -0400, J. Bruce Fields wrote: > > From: J. Bruce Fields > > > > Bring lease exports into line with conventions for posix locks: > > setlease() should be exported so filesystems can use it to implement > > their lease methods. > > vfs_setlease() need only be GPL-exported since only nfsd > > needs it. > > The latter should be merged in the previous patch, the first should > be a patch with making it non-static and exporting it. (after the > rename of it is merged into the patch that introduces the vfs_setlease > name) Done.--b.