From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 6/6] nfs: disable leases over NFS Date: Wed, 11 Jul 2007 11:20:18 +0100 Message-ID: <20070711102018.GA21947@infradead.org> References: <6e0beaf3e950494a6903571f0b5c9b61fc7bf650.1183143819.git.bfields@citi.umich.edu> <20070630092516.GD22050@infradead.org> <20070705154100.GC29867@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Andrew Morton , linux-fsdevel@vger.kernel.org, Peter Staubach , Trond Myklebust To: "J. Bruce Fields" Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:41893 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760498AbXGKKUZ (ORCPT ); Wed, 11 Jul 2007 06:20:25 -0400 Content-Disposition: inline In-Reply-To: <20070705154100.GC29867@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jul 05, 2007 at 11:41:00AM -0400, J. Bruce Fields wrote: > OK, after looking at this a little more, I'm less happy about the idea > of erroring out by default: > > - There are a ton of filesystems that probably should allow > leases, and only a few (network filesystems) that shouldn't, > so leaving leases on by default seems simpler. But it gets you possible wrong behaviour by default. I'm not a big fan of non-trivial default methods as you see :) > - We already fall back on the local method by default in the case > of locks, and I don't see a reason to treat leases differently. > - The patch to add > .setlease = setlease, > to all the file_operations is going to be a big patch that > changes behavior in a way that might be easy to miss (because > it changes behavior exactly on those filesystems it *doesn't* > touch.) I think it'll be easier to get better review on the > patch that adds a method just to those filesystems that we're > disabling leases for. Anyway, feel free to go ahead with the simpler version for now, I'll do the switchover for locks and leases when I get some time.