From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dwmw2@infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: -mm merge plans for 2.6.23
Date: Wed, 11 Jul 2007 13:35:53 +0200 [thread overview]
Message-ID: <20070711113553.GA18665@lst.de> (raw)
In-Reply-To: <20070710013152.ef2cd200.akpm@linux-foundation.org>
On Tue, Jul 10, 2007 at 01:31:52AM -0700, Andrew Morton wrote:
> romfs-printk-format-warnings.patch
NACK on this one. This bloats romfs by almost half of it's previous
size to add mtd support to it. Given that romfs is a compltely
trivial filesystem it's much better to have a separate filesystem
driver handling the format on mtd instead of adding all these
indirections. In addition to that argument the switch on the
underlying subsystem is done horrible. There's lots of ifdefs instead
of proper functions pointers, there's one file containing both block
and mtd code instead of seaparate files, etc.
And the get_unmapped_area method in a bare filesystem needs a _lot_
of explanation.
next parent reply other threads:[~2007-07-11 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070710013152.ef2cd200.akpm@linux-foundation.org>
2007-07-11 11:35 ` Christoph Hellwig [this message]
2007-07-11 11:39 ` -mm merge plans for 2.6.23 David Woodhouse
2007-07-11 17:21 ` Andrew Morton
2007-07-11 17:28 ` Randy Dunlap
2007-07-11 12:00 ` fallocate, " Christoph Hellwig
[not found] ` <46957BE1.1010104@yahoo.com.au>
2007-07-12 2:31 ` block_page_mkwrite? (Re: fault vs invalidate race (Re: -mm merge plans for 2.6.23)) David Chinner
2007-07-12 2:42 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711113553.GA18665@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).