From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Mingming Cao <cmm@us.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update
Date: Wed, 11 Jul 2007 13:02:47 +0100 [thread overview]
Message-ID: <20070711120247.GA26370@infradead.org> (raw)
In-Reply-To: <20070711115224.GT6417@schatzie.adilger.int>
On Wed, Jul 11, 2007 at 05:52:24AM -0600, Andreas Dilger wrote:
> On Jul 11, 2007 09:47 +0100, Christoph Hellwig wrote:
> > On Sun, Jul 01, 2007 at 03:37:45AM -0400, Mingming Cao wrote:
> > > This patch is on top of i_version_update_vfs.
> > > The i_version field of the inode is set on inode creation and incremented
> > > when the inode is being modified.
> >
> > Which is not what i_version is supposed to do. It'll get you tons of misses
> > for NFSv3 filehandles that rely on the generation staying the same for the
> > same file. Please add a new field for the NFSv4 sequence counter instead
> > of making i_version unuseable.
>
> You are confusing i_generation (the instance of this inode number) with
> i_version (whether this file has been modified)?
Yes, sorry. Objection dropped.
next prev parent reply other threads:[~2007-07-11 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:37 [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update Mingming Cao
2007-07-03 6:49 ` Aneesh Kumar K.V
2007-07-03 21:41 ` Andreas Dilger
2007-07-10 23:31 ` Andrew Morton
2007-07-11 8:47 ` Christoph Hellwig
2007-07-11 11:52 ` Andreas Dilger
2007-07-11 12:02 ` Christoph Hellwig [this message]
2007-07-11 11:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711120247.GA26370@infradead.org \
--to=hch@infradead.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).