From: Dave Hansen <haveblue@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
hch@infradead.org, Dave Hansen <haveblue@us.ibm.com>
Subject: [PATCH 20/23] elevate write count for do_sys_utime() and touch_atime()
Date: Wed, 11 Jul 2007 17:17:37 -0700 [thread overview]
Message-ID: <20070712001737.7E9156D0@kernel> (raw)
In-Reply-To: <20070712001710.654CD9ED@kernel>
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---
lxc-dave/fs/inode.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff -puN fs/inode.c~elevate-write-count-for-do-sys-utime-and-touch-atime fs/inode.c
--- lxc/fs/inode.c~elevate-write-count-for-do-sys-utime-and-touch-atime 2007-07-10 12:46:15.000000000 -0700
+++ lxc-dave/fs/inode.c 2007-07-10 12:46:15.000000000 -0700
@@ -1165,22 +1165,23 @@ void touch_atime(struct vfsmount *mnt, s
struct inode *inode = dentry->d_inode;
struct timespec now;
- if (inode->i_flags & S_NOATIME)
+ if (mnt && mnt_want_write(mnt))
return;
+ if (inode->i_flags & S_NOATIME)
+ goto out;
if (IS_NOATIME(inode))
- return;
+ goto out;
if ((inode->i_sb->s_flags & MS_NODIRATIME) && S_ISDIR(inode->i_mode))
- return;
+ goto out;
/*
* We may have a NULL vfsmount when coming from NFSD
*/
if (mnt) {
if (mnt->mnt_flags & MNT_NOATIME)
- return;
+ goto out;
if ((mnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode))
- return;
-
+ goto out;
if (mnt->mnt_flags & MNT_RELATIME) {
/*
* With relative atime, only update atime if the
@@ -1191,16 +1192,19 @@ void touch_atime(struct vfsmount *mnt, s
&inode->i_atime) < 0 &&
timespec_compare(&inode->i_ctime,
&inode->i_atime) < 0)
- return;
+ goto out;
}
}
now = current_fs_time(inode->i_sb);
if (timespec_equal(&inode->i_atime, &now))
- return;
+ goto out;
inode->i_atime = now;
mark_inode_dirty_sync(inode);
+out:
+ if (mnt)
+ mnt_drop_write(mnt);
}
EXPORT_SYMBOL(touch_atime);
_
next prev parent reply other threads:[~2007-07-12 0:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 0:17 [PATCH 00/23] Mount writer count API (read-only bind mounts prep) Dave Hansen
2007-07-12 0:17 ` [PATCH 01/23] rearrange may_open() to be r/o friendly Dave Hansen
2007-07-12 0:17 ` [PATCH 02/23] create cleanup helper svc_msnfs() Dave Hansen
2007-07-12 0:17 ` [PATCH 03/23] filesystem helpers for custom 'struct file's Dave Hansen
2007-07-12 0:17 ` [PATCH 04/23] r/o bind mounts: stub functions Dave Hansen
2007-07-12 0:17 ` [PATCH 05/23] elevate write count open()'d files Dave Hansen
2007-07-12 0:17 ` [PATCH 06/23] r/o bind mounts: elevate write count for some ioctls Dave Hansen
2007-07-12 0:17 ` [PATCH 07/23] elevate writer count for chown and friends Dave Hansen
2007-07-12 0:17 ` [PATCH 08/23] make access() use mnt check Dave Hansen
2007-07-12 0:17 ` [PATCH 09/23] elevate mnt writers for callers of vfs_mkdir() Dave Hansen
2007-07-12 0:17 ` [PATCH 10/23] elevate write count during entire ncp_ioctl() Dave Hansen
2007-07-12 0:17 ` [PATCH 11/23] elevate write count for link and symlink calls Dave Hansen
2007-07-12 0:17 ` [PATCH 12/23] elevate mount count for extended attributes Dave Hansen
2007-07-12 0:17 ` [PATCH 13/23] elevate write count for file_update_time() Dave Hansen
2007-07-12 0:17 ` [PATCH 14/23] mount_is_safe(): add comment Dave Hansen
2007-07-12 0:17 ` [PATCH 15/23] unix_find_other() elevate write count for touch_atime() Dave Hansen
2007-07-12 0:17 ` [PATCH 16/23] elevate write count over calls to vfs_rename() Dave Hansen
2007-07-12 0:17 ` [PATCH 17/23] nfs: check mnt instead of superblock directly Dave Hansen
2007-07-12 0:17 ` [PATCH 18/23] elevate writer count for do_sys_truncate() Dave Hansen
2007-07-12 0:17 ` [PATCH 19/23] elevate write count for do_utimes() Dave Hansen
2007-07-12 0:17 ` Dave Hansen [this message]
2007-07-12 0:17 ` [PATCH 21/23] sys_mknodat(): elevate write count for vfs_mknod/create() Dave Hansen
2007-07-12 0:17 ` [PATCH 22/23] elevate mnt writers for vfs_unlink() callers Dave Hansen
2007-07-12 0:17 ` [PATCH 23/23] do_rmdir(): elevate write count Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070712001737.7E9156D0@kernel \
--to=haveblue@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).