From mboxrd@z Thu Jan 1 00:00:00 1970 From: WANG Cong Subject: [Patch] fs/romfs/inode.c: trivial improvements Date: Wed, 18 Jul 2007 16:35:17 +0800 Message-ID: <20070718083517.GA6179@localhost.localdomain> Reply-To: WANG Cong Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, LKML , viro@zeniv.linux.org.uk, akpm@linux-foundation.org To: chexum@shadow.banki.hu Return-path: Received: from wa-out-1112.google.com ([209.85.146.177]:31663 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbXGRIcf (ORCPT ); Wed, 18 Jul 2007 04:32:35 -0400 Received: by wa-out-1112.google.com with SMTP id v27so131622wah for ; Wed, 18 Jul 2007 01:32:34 -0700 (PDT) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org 1. There's no lists in fs/romfs/inode.c, so using list_entry is a bit confusing. Replace it with container_of. 2. It is unnecessary to cast the return value of kmem_cache_alloc, since it returns a void* pointer. This patch is against 2.6.22.1. Signed-off-by: WANG Cong --- fs/romfs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.22.1/fs/romfs/inode.c =================================================================== --- linux-2.6.22.1.orig/fs/romfs/inode.c 2007-07-12 00:47:28.000000000 +0800 +++ linux-2.6.22.1/fs/romfs/inode.c 2007-07-18 16:08:56.000000000 +0800 @@ -92,7 +92,7 @@ static inline struct romfs_inode_info *ROMFS_I(struct inode *inode) { - return list_entry(inode, struct romfs_inode_info, vfs_inode); + return container_of(inode, struct romfs_inode_info, vfs_inode); } static __u32 @@ -555,7 +555,7 @@ static struct inode *romfs_alloc_inode(struct super_block *sb) { struct romfs_inode_info *ei; - ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL); + ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL); if (!ei) return NULL; return &ei->vfs_inode;