From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] block: factor out bio_check_eod() Date: Wed, 18 Jul 2007 13:31:03 +0200 Message-ID: <20070718113103.GO11657@kernel.dk> References: <18006.38689.818186.221707@notabene.brown> <18010.12472.209452.148229@notabene.brown> <20070530093503.GA15559@kernel.dk> <20070718105655.GB22374@htj.dyndns.org> <20070718105946.GC22374@htj.dyndns.org> <20070718110619.GM11657@kernel.dk> <469DF700.4030806@gmail.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Chinner , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Phillip Susi , Andreas Dilger To: Tejun Heo Return-path: Content-Disposition: inline In-Reply-To: <469DF700.4030806@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com List-Id: linux-fsdevel.vger.kernel.org On Wed, Jul 18 2007, Tejun Heo wrote: > Jens Axboe wrote: > > On Wed, Jul 18 2007, Tejun Heo wrote: > >> End of device check is done twice in __generic_make_request() and it's > >> fully inlined each time. Factor out bio_check_eod(). > > > > Tejun, yeah I should seperate the cleanups and put them in the upstream > > branch. Will do so and add your signed-off to both of them. > > > > Would they be different from the one I just posted? No big deal either > way. I'm just basing the zero-length barrier on top of these patches. > Oh well, the changes are trivial anyway. This one ended up being the same, but in the first one you missed some of the cleanups. I ended up splitting the patch some more though, see the series: http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=barrier -- Jens Axboe