From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] coda: kill file_count abuse
Date: Fri, 20 Jul 2007 10:45:34 +1000 [thread overview]
Message-ID: <20070720004534.GA31489@sgi.com> (raw)
In-Reply-To: <20070719221559.GI8857@delft.aura.cs.cmu.edu>
On Thu, Jul 19, 2007 at 06:16:00PM -0400, Jan Harkes wrote:
> On Thu, Jul 19, 2007 at 11:45:08PM +0200, Christoph Hellwig wrote:
> > ->release is the proper way to detect the last close of a file,
> > file_count should never be used in filesystems.
>
> Has been tried, the problem with that once ->release is called it is too
> late to pass the the error back to close(2).
I think you'll find the problem is that fput() throws away the error
from ->release, not that it's too late....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-07-20 0:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 21:45 [PATCH] coda: kill file_count abuse Christoph Hellwig
2007-07-19 22:16 ` Jan Harkes
2007-07-20 0:45 ` David Chinner [this message]
2007-07-20 0:53 ` Al Viro
2007-07-20 2:36 ` David Chinner
2007-07-20 3:16 ` Al Viro
2007-07-20 4:10 ` [PATCH] coda: file count cannot be used to discover last close Jan Harkes
2007-07-20 5:38 ` Al Viro
2007-07-20 14:26 ` Jan Harkes
2007-07-20 6:03 ` [PATCH] coda: kill file_count abuse David Chinner
2007-07-20 2:40 ` Jan Harkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720004534.GA31489@sgi.com \
--to=dgc@sgi.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).