From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Chinner Subject: Re: [PATCH] coda: kill file_count abuse Date: Fri, 20 Jul 2007 10:45:34 +1000 Message-ID: <20070720004534.GA31489@sgi.com> References: <20070719214508.GA4482@lst.de> <20070719221559.GI8857@delft.aura.cs.cmu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org Return-path: Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:41707 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935148AbXGTAps (ORCPT ); Thu, 19 Jul 2007 20:45:48 -0400 Content-Disposition: inline In-Reply-To: <20070719221559.GI8857@delft.aura.cs.cmu.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jul 19, 2007 at 06:16:00PM -0400, Jan Harkes wrote: > On Thu, Jul 19, 2007 at 11:45:08PM +0200, Christoph Hellwig wrote: > > ->release is the proper way to detect the last close of a file, > > file_count should never be used in filesystems. > > Has been tried, the problem with that once ->release is called it is too > late to pass the the error back to close(2). I think you'll find the problem is that fput() throws away the error from ->release, not that it's too late.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group