linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: swhiteho@redhat.com
Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org
Subject: do_generic_mapping_read abuse in gfs2
Date: Sat, 28 Jul 2007 19:42:38 +0200	[thread overview]
Message-ID: <20070728174238.GA5805@lst.de> (raw)

I was looking into cleaning up the the read actor mess now that sendfile
uses splice and notices gfs2 now uses do_generic_mapping_read.

The use is rather odd because it's used for reading small structures
from kernelspace and thus doesn't actually needs the fullblown
do_generic_mapping_read at all.  Any chance you could switch it to
a simple read_cache_page() so we can kill do_generic_mapping_read?

             reply	other threads:[~2007-07-28 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-28 17:42 Christoph Hellwig [this message]
2007-07-29 13:42 ` do_generic_mapping_read abuse in gfs2 Steven Whitehouse
2007-08-27 16:24   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070728174238.GA5805@lst.de \
    --to=hch@lst.de \
    --cc=cluster-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).