From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Alex Tomas <alex@clusterfs.com>, Jeff Garzik <jeff@garzik.org>,
ext4 development <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC] basic delayed allocation in VFS
Date: Sat, 28 Jul 2007 20:53:30 +0100 [thread overview]
Message-ID: <20070728195330.GB5952@infradead.org> (raw)
In-Reply-To: <20070727050714.GS12413810@sgi.com>
On Fri, Jul 27, 2007 at 03:07:14PM +1000, David Chinner wrote:
> > It duplicates fs/mpage.c in bio building and introduces new generic API
> > (iomap, map_blocks_t, etc).
>
> Using a new API for new functionality is a bad thing?
Depends on wht you do. This patch is just a quickhack to shoe-horn
delalloc support into ext4. Introducing a new abstraction is overkill.
If we really want an overhaul of the writeback path that's extent-aware,
and efficient for delalloc and unwritten extents introducing a proper
iomap-like data structure would make sense. That beeing said I personally
hate the ubffer_head abuse for bmap data that we have in various places
as it's utterly confusing and wasting stack space, but that's a different
discussion.
next prev parent reply other threads:[~2007-07-28 19:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 8:59 [RFC] basic delayed allocation in VFS Alex Tomas
2007-07-26 10:32 ` Jeff Garzik
2007-07-26 10:35 ` Alex Tomas
2007-07-26 12:05 ` Jeff Garzik
2007-07-26 13:33 ` Alex Tomas
2007-07-27 5:07 ` David Chinner
2007-07-27 7:51 ` Alex Tomas
2007-07-27 12:33 ` Jeff Garzik
2007-07-27 12:42 ` Alex Tomas
2007-07-28 19:56 ` Christoph Hellwig
2007-07-29 9:18 ` David Chinner
2007-07-29 12:09 ` Alex Tomas
2007-07-30 0:29 ` David Chinner
2007-07-27 12:38 ` Alex Tomas
2007-07-28 19:57 ` Christoph Hellwig
2007-07-28 19:53 ` Christoph Hellwig [this message]
2007-07-28 19:51 ` Christoph Hellwig
2007-07-28 19:56 ` Alex Tomas
2007-07-29 17:30 ` Andreas Dilger
2007-07-29 17:48 ` Alex Tomas
2007-07-29 19:22 ` Christoph Hellwig
2007-07-29 19:24 ` Christoph Hellwig
2007-07-29 19:51 ` Alex Tomas
2007-07-30 0:28 ` Theodore Tso
2007-07-30 17:49 ` Mingming Cao
2007-07-30 19:43 ` Andrew Morton
2007-07-26 11:47 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070728195330.GB5952@infradead.org \
--to=hch@infradead.org \
--cc=alex@clusterfs.com \
--cc=dgc@sgi.com \
--cc=jeff@garzik.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).