From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Garzik <jeff@garzik.org>, Alex Tomas <alex@clusterfs.com>,
ext4 development <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] basic delayed allocation in VFS
Date: Sun, 29 Jul 2007 20:28:41 -0400 [thread overview]
Message-ID: <20070730002840.GA7202@thunk.org> (raw)
In-Reply-To: <20070729192437.GB14530@infradead.org>
On Sun, Jul 29, 2007 at 08:24:37PM +0100, Christoph Hellwig wrote:
> I'm a big proponent of having proper common delalloc code, but the
> one proposed here is not generic for the existing filesystem using
> delalloc. It's still on my todo list to revamp the xfs code to get
> rid of some of the existing mess and make it useable genericly. If
> the ext4 users are fine with the end result we could move to generic
> code.
Do you think it would be faster for you to revamp the code or to give
instructions about how you'd like to clean up the code and what has to
be preserved in order to keep XFS happy, so someone else could give it
a try? Or do you think the code is to grotty and/or tricky for
someone else to attempt this?
> Note that moving to VFS is bullshit either way, writeback code is
> nowhere near the VFS nor should it.
Agreed. I would think the something like mm/delayed_alloc.c would be
preferable. Ideally it would be like the filemap.c code, where it
would be relatively easy for most standard filesystems to hook into it
and get the advantages of delayed allocation. (Although granted it
will probably require more effort on the part of a filesystem author
than filemap!)
- Ted
next prev parent reply other threads:[~2007-07-30 0:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 8:59 [RFC] basic delayed allocation in VFS Alex Tomas
2007-07-26 10:32 ` Jeff Garzik
2007-07-26 10:35 ` Alex Tomas
2007-07-26 12:05 ` Jeff Garzik
2007-07-26 13:33 ` Alex Tomas
2007-07-27 5:07 ` David Chinner
2007-07-27 7:51 ` Alex Tomas
2007-07-27 12:33 ` Jeff Garzik
2007-07-27 12:42 ` Alex Tomas
2007-07-28 19:56 ` Christoph Hellwig
2007-07-29 9:18 ` David Chinner
2007-07-29 12:09 ` Alex Tomas
2007-07-30 0:29 ` David Chinner
2007-07-27 12:38 ` Alex Tomas
2007-07-28 19:57 ` Christoph Hellwig
2007-07-28 19:53 ` Christoph Hellwig
2007-07-28 19:51 ` Christoph Hellwig
2007-07-28 19:56 ` Alex Tomas
2007-07-29 17:30 ` Andreas Dilger
2007-07-29 17:48 ` Alex Tomas
2007-07-29 19:22 ` Christoph Hellwig
2007-07-29 19:24 ` Christoph Hellwig
2007-07-29 19:51 ` Alex Tomas
2007-07-30 0:28 ` Theodore Tso [this message]
2007-07-30 17:49 ` Mingming Cao
2007-07-30 19:43 ` Andrew Morton
2007-07-26 11:47 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730002840.GA7202@thunk.org \
--to=tytso@mit.edu \
--cc=alex@clusterfs.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).