From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [Patch 05/18] fs/logfs/dir.c Date: Wed, 8 Aug 2007 19:41:39 +0200 Message-ID: <20070808174137.GW15319@lazybastard.org> References: <20070808161234.GB15319@lazybastard.org> <20070808161626.GG15319@lazybastard.org> <1186592854.19606.49.camel@sauron> <20070808171554.GV15319@lazybastard.org> <1186594474.19606.52.camel@sauron> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?utf-8?B?SsO2cm4=?= Engel , akpm@osdl.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Thomas Gleixner , David Woodhouse To: Artem Bityutskiy Return-path: Received: from lazybastard.de ([212.112.238.170]:41290 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758771AbXHHRpx (ORCPT ); Wed, 8 Aug 2007 13:45:53 -0400 Content-Disposition: inline In-Reply-To: <1186594474.19606.52.camel@sauron> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 8 August 2007 20:34:34 +0300, Artem Bityutskiy wrote: > On Wed, 2007-08-08 at 19:15 +0200, J=C3=B6rn Engel wrote: > > On Wed, 8 August 2007 20:07:34 +0300, Artem Bityutskiy wrote: > > > On Wed, 2007-08-08 at 18:16 +0200, J=C3=B6rn Engel wrote: > > > > +static inline void logfs_inc_count(struct inode *inode) > > > > +{ > > > > + inode->i_nlink++; > > > > + mark_inode_dirty_sync(inode); > > > > +} > > > > + > > > > +static inline void logfs_dec_count(struct inode *inode) > > > > +{ > > > > + inode->i_nlink--; > > > > + mark_inode_dirty_sync(inode); > > > > +} > > > include/linux/fs.h: inode_inc_link_count() inode_dec_link_count()= do > > > this. Although not sure they exist in the old kernel your patches= are > > > against. > >=20 > > Almost, they call mark_inode_dirty() instead of mark_inode_dirty_sy= nc(). > > I wonder if that's necessary. > >=20 > Ah, right, it is necessary as long as you do not have write-back > implemented, sure. Pardon :-) Write-back has nothing to do with this. When calling logfs_inc_count() the only thing that needs writeback is the inode itself. Marking pages and buffers dirty as well is pure paranoia or laziness, your pick. J=C3=B6rn --=20 When I am working on a problem I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong. -- R. Buckminster Fuller - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html