From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: [PATCH 4/4] writeback: fix ntfs with sb_has_dirty_inodes() Date: Fri, 10 Aug 2007 14:34:16 +0800 Message-ID: <386727660.64743@ustc.edu.cn> References: <20070810063412.238042387@mail.ustc.edu.cn> Cc: Ken Chen , Anton Altaparmakov , Andrew Morton To: Andrew Morton Return-path: Received: from smtp.ustc.edu.cn ([202.38.64.16]:53388 "HELO ustc.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1753177AbXHJGeZ (ORCPT ); Fri, 10 Aug 2007 02:34:25 -0400 Message-Id: <20070810063419.786586676@mail.ustc.edu.cn> Cc: Miklos Szeredi Cc: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Content-Disposition: inline; filename=nfs-dirty-inodes.patch Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org NTFS's if-condition on dirty inodes is not complete. Fix it with sb_has_dirty_inodes(). Cc: Anton Altaparmakov Cc: Ken Chen Cc: Andrew Morton Signed-off-by: Fengguang Wu --- --- linux-2.6.23-rc1-mm2.orig/fs/ntfs/super.c +++ linux-2.6.23-rc1-mm2/fs/ntfs/super.c @@ -2381,14 +2381,14 @@ static void ntfs_put_super(struct super_ */ ntfs_commit_inode(vol->mft_ino); write_inode_now(vol->mft_ino, 1); - if (!list_empty(&sb->s_dirty)) { + if (sb_has_dirty_inodes(sb)) { const char *s1, *s2; mutex_lock(&vol->mft_ino->i_mutex); truncate_inode_pages(vol->mft_ino->i_mapping, 0); mutex_unlock(&vol->mft_ino->i_mutex); write_inode_now(vol->mft_ino, 1); - if (!list_empty(&sb->s_dirty)) { + if (sb_has_dirty_inodes(sb)) { static const char *_s1 = "inodes"; static const char *_s2 = ""; s1 = _s1; --- linux-2.6.23-rc1-mm2.orig/include/linux/fs.h +++ linux-2.6.23-rc1-mm2/include/linux/fs.h @@ -1772,6 +1772,7 @@ extern int bdev_read_only(struct block_d extern int set_blocksize(struct block_device *, int); extern int sb_set_blocksize(struct super_block *, int); extern int sb_min_blocksize(struct super_block *, int); +extern int sb_has_dirty_inodes(struct super_block *); extern int generic_file_mmap(struct file *, struct vm_area_struct *); extern int generic_file_readonly_mmap(struct file *, struct vm_area_struct *); -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: [PATCH 4/4] writeback: fix ntfs with sb_has_dirty_inodes() Date: Fri, 10 Aug 2007 14:34:16 +0800 Message-ID: <20070810063419.786586676__41574.3797355846$1186727772$gmane$org@mail.ustc.edu.cn> References: <20070810063412.238042387@mail.ustc.edu.cn> Cc: Ken Chen , Anton Altaparmakov , Andrew Morton To: Andrew Morton Return-path: Message-Id: <20070810063419.786586676@mail.ustc.edu.cn> Cc: Miklos Szeredi Cc: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Content-Disposition: inline; filename=nfs-dirty-inodes.patch Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org NTFS's if-condition on dirty inodes is not complete. Fix it with sb_has_dirty_inodes(). Cc: Anton Altaparmakov Cc: Ken Chen Cc: Andrew Morton Signed-off-by: Fengguang Wu --- --- linux-2.6.23-rc1-mm2.orig/fs/ntfs/super.c +++ linux-2.6.23-rc1-mm2/fs/ntfs/super.c @@ -2381,14 +2381,14 @@ static void ntfs_put_super(struct super_ */ ntfs_commit_inode(vol->mft_ino); write_inode_now(vol->mft_ino, 1); - if (!list_empty(&sb->s_dirty)) { + if (sb_has_dirty_inodes(sb)) { const char *s1, *s2; mutex_lock(&vol->mft_ino->i_mutex); truncate_inode_pages(vol->mft_ino->i_mapping, 0); mutex_unlock(&vol->mft_ino->i_mutex); write_inode_now(vol->mft_ino, 1); - if (!list_empty(&sb->s_dirty)) { + if (sb_has_dirty_inodes(sb)) { static const char *_s1 = "inodes"; static const char *_s2 = ""; s1 = _s1; --- linux-2.6.23-rc1-mm2.orig/include/linux/fs.h +++ linux-2.6.23-rc1-mm2/include/linux/fs.h @@ -1772,6 +1772,7 @@ extern int bdev_read_only(struct block_d extern int set_blocksize(struct block_device *, int); extern int sb_set_blocksize(struct super_block *, int); extern int sb_min_blocksize(struct super_block *, int); +extern int sb_has_dirty_inodes(struct super_block *); extern int generic_file_mmap(struct file *, struct vm_area_struct *); extern int generic_file_readonly_mmap(struct file *, struct vm_area_struct *); --