From: Andreas Gruenbacher <agruen@suse.de>
To: casey@schaufler-ca.com
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, viro@ftp.linux.org.uk, sds@tycho.nsa.gov,
linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org,
linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov,
linux-security-module@vger.kernel.org
Subject: Re: Adding a security parameter to VFS functions
Date: Fri, 17 Aug 2007 00:20:19 +0200 [thread overview]
Message-ID: <200708170020.19939.agruen@suse.de> (raw)
In-Reply-To: <45343.31878.qm@web36610.mail.mud.yahoo.com>
On Wednesday 15 August 2007 18:23, Casey Schaufler wrote:
> > Hi Linus, Al,
> >
> > Would you object greatly to functions like vfs_mkdir() gaining a security
> > parameter?
>
> Could you describe how this compares to the proposal that the
> AppArmor developers suggested recently? I expect that we can
> reduce the amount of discussion required, and maybe avoid some
> confusion if you could do that.
That's from one of those patches:
-int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
+int vfs_mkdir(struct inode *dir, struct dentry *dentry, struct vfsmount *mnt,
+ int mode)
We need the vfsmount in the LSM hooks in addition to the dentry in order to
figure out where in the filesystem namespace we are. The various vfs_
functions are the ones calling the LSM hooks. (The same could be achieved
passing a struct path instead.)
-- Andreas
next prev parent reply other threads:[~2007-08-16 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 11:40 Adding a security parameter to VFS functions David Howells
2007-08-15 16:23 ` Casey Schaufler
2007-08-15 16:52 ` David Howells
2007-08-16 22:20 ` Andreas Gruenbacher [this message]
2007-08-16 22:36 ` Andreas Gruenbacher
2007-08-16 22:57 ` Linus Torvalds
2007-08-16 23:30 ` Kyle Moffett
2007-08-16 23:34 ` Al Viro
2007-08-17 18:05 ` Andreas Gruenbacher
2007-08-20 12:09 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708170020.19939.agruen@suse.de \
--to=agruen@suse.de \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).