From: Alasdair G Kergon <agk@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [RFC] block_device_operations prototype changes
Date: Mon, 27 Aug 2007 23:59:01 +0100 [thread overview]
Message-ID: <20070827225901.GB30122@agk.fab.redhat.com> (raw)
In-Reply-To: <20070827103053.GF21089@ftp.linux.org.uk>
On Mon, Aug 27, 2007 at 11:30:53AM +0100, Al Viro wrote:
> 3) ->ioctl(). What a mess...
Yup.
See also:
Subject: [PATCH] dm: support ioctls on mapped devices: fix with fake file
http://uwsg.indiana.edu/hypermail/linux/kernel/0606.2/2979.html
and related threads.
> First of all, we have 3 methods with different
> calling conventions:
> ->ioctl(inode, file, cmd, arg)
> ->unlocked_ioctl(inode, file, cmd, arg)
When I last looked it was:
long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);
with the lack of inode forcing dm to use ->ioctl (because file can be NULL when
only the block device is known) and immediately drop the pointless-for-us
lock!
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-08-27 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 10:30 [RFC] block_device_operations prototype changes Al Viro
2007-08-27 16:35 ` Linus Torvalds
2007-08-27 22:59 ` Alasdair G Kergon [this message]
2007-08-27 23:33 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070827225901.GB30122@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).