From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs-client@lists.samba.org, nfs@lists.sourceforge.net
Subject: Re: [PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations
Date: Thu, 30 Aug 2007 17:33:56 +0100 [thread overview]
Message-ID: <20070830163356.GA12512@infradead.org> (raw)
In-Reply-To: <200708301506.l7UF6c63002133@dantu.rdu.redhat.com>
On Thu, Aug 30, 2007 at 11:06:38AM -0400, Jeff Layton wrote:
> Make notify_change not clear the ATTR_KILL_S*ID bits in the ia_vaid that
> gets passed to the setattr inode operation. This allows the filesystems
> to reinterpret whether this mode change is simply intended to clear the
> setuid/setgid bits.
>
> This means that notify_change should never be called with both ATTR_MODE
> and either of the ATTR_KILL_S*ID bits set, since the filesystem would
> have no way to know what part of the mode change was intentional. If
> it is called this way, consider it a BUG().
This one looks fine to, but you'll probably need an additional patch
to ecryptfs so it clears ATTR_MODE before calling notify_change for
the lower inode.
prev parent reply other threads:[~2007-08-30 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 15:06 [PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations Jeff Layton
2007-08-30 16:03 ` Peter Staubach
2007-08-30 16:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070830163356.GA12512@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).