linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: "Marti Raudsepp" <marti@juffo.org>
Cc: reiserfs-devel <reiserfs-devel@vger.kernel.org>,
	fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: ReiserFS: clm-2100: nesting info a different FS
Date: Mon, 10 Sep 2007 09:40:16 -0400	[thread overview]
Message-ID: <20070910094016.5ca9f72e@think.oraclecorp.com> (raw)
In-Reply-To: <2a12af650709060731m64d7ff9es7f702d5c300cfcc2@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On Thu, 6 Sep 2007 17:31:53 +0300
"Marti Raudsepp" <marti@juffo.org> wrote:

> Hi,
> 
> My dmesg output contains a lot of warning messages from reiserfs and
> I'm wondering if this is anything important:
> ReiserFS: dm-0: warning: clm-2100: nesting info a different FS
> 
> I'm running Hardened Gentoo kernel 2.6.16-r11 on AMD64. I've got three
> reiserfs filesystems: one for root which is mounted directly from a
> RAID1 array (/dev/md/2), and two are LVM volumes from another RAID1
> array (/dev/md/3); one of the latter has usrquota enabled. I'm not
> really sure which block device "dm-0" refers to. The computer is doing
> relatively little disk I/O most of the time.
> 
> The comment in fs/reiserfs/journal.c says:
> /* we've ended up with a handle from a different filesystem.
>  ** save it and restore on journal_end.  This should never
>  ** really happen...
>  */
> 
> The "should never really happen" part made me wonder, is this anything
> I should be worried about?

Well, it's really not supposed to happen, and hopefully it indicates
that someone is doing an allocation without GFP_NOFS when they really
should be using it.  A simple stack trace will show us pretty quickly.

Can you try a patch to add a stack trace to this warning?  I've
attached it.

-chris

[-- Attachment #2: warning.patch --]
[-- Type: text/x-patch, Size: 410 bytes --]

diff -r 70b4267862e0 fs/reiserfs/journal.c
--- a/fs/reiserfs/journal.c	Mon Jul 09 00:00:31 2007 +0000
+++ b/fs/reiserfs/journal.c	Mon Sep 10 09:37:39 2007 -0400
@@ -3165,6 +3165,7 @@ int journal_begin(struct reiserfs_transa
 			 */
 			reiserfs_warning(p_s_sb,
 					 "clm-2100: nesting info a different FS");
+			WARN_ON(1);
 			th->t_handle_save = current->journal_info;
 			current->journal_info = th;
 		}

      reply	other threads:[~2007-09-10 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 14:31 ReiserFS: clm-2100: nesting info a different FS Marti Raudsepp
2007-09-10 13:40 ` Chris Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070910094016.5ca9f72e@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=marti@juffo.org \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).