From: Christoph Hellwig <hch@lst.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-fsdevel@vger.kernel.org, Neil Brown <neilb@suse.de>,
nfs@lists.sourceforge.net, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATH 08/19] jfs: new export ops
Date: Thu, 13 Sep 2007 15:59:34 +0200 [thread overview]
Message-ID: <20070913135933.GA11411@lst.de> (raw)
In-Reply-To: <20070910194533.GA18793@fieldses.org>
On Mon, Sep 10, 2007 at 03:45:33PM -0400, J. Bruce Fields wrote:
> On Thu, Aug 30, 2007 at 03:16:32PM +0200, Christoph Hellwig wrote:
> > Trivial switch over to the new generic helpers.
> > - result = ERR_PTR(-ESTALE);
> > - goto out_iput;
> > + iput(inode);
> > + return ERR_PTR(-ESTALE);
>
> For some reason you're introducing a bunch of whitespace damage on lines
> like that last one. Would you mind running these through checkpatch.pl
> or whatever and then resending?
>
> Other than that I can't find any problem, and it seems like an obvious
> improvement, though I'd like to see Neil take a look. Do you want these
> added to the nfsd patches for 2.6.24?
Yes, please add them to the queue. I've put a quilt series of patches
with the whitespace fixe on http://verein.lst.de/~hch/patches.nfsd.tgz.
Do you want to take it that way or should I resend everything to the
list?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-09-13 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 13:16 [PATH 08/19] jfs: new export ops Christoph Hellwig
2007-09-10 19:45 ` [NFS] " J. Bruce Fields
2007-09-13 13:59 ` Christoph Hellwig [this message]
2007-09-13 20:57 ` J. Bruce Fields
2007-09-13 21:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913135933.GA11411@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).