From: Christoph Hellwig <hch@lst.de>
To: Greg Banks <gnb@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>,
nfs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Subject: Re: [NFS] [PATH 04/19] ext2: new export ops
Date: Fri, 14 Sep 2007 17:01:09 +0200 [thread overview]
Message-ID: <20070914150109.GA4154@lst.de> (raw)
In-Reply-To: <20070914145803.GH21965@sgi.com>
On Sat, Sep 15, 2007 at 12:58:03AM +1000, Greg Banks wrote:
> These patches look good, and cleanup in this area is certainly a
> good thing. One small comment: the easy filesystems (ext[234], efs,
> ntfs) might be cleaner if the per-fs get_inode function were a member
> of export_ops instead of an extra argument to generic_fh_to_dentry().
> That way you wouldn't need these two little helper functions in each
> filesystem, because you could point export_ops.fh_to_dentry directly
> at generic_fh_to_dentry.
I was pondering this, but in the end I prefer the cleaner layering of
the callback version. This also mirrors what we do in other areas
(e.g. address_space operations)
prev parent reply other threads:[~2007-09-14 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 13:16 [PATH 04/19] ext2: new export ops Christoph Hellwig
2007-09-14 14:58 ` Greg Banks
2007-09-14 15:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070914150109.GA4154@lst.de \
--to=hch@lst.de \
--cc=gnb@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).