From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/5] VFS: pass open file to ->xattr()
Date: Fri, 21 Sep 2007 13:43:23 +0100 [thread overview]
Message-ID: <20070921124323.GA8088@infradead.org> (raw)
In-Reply-To: <20070921123333.247493758@szeredi.hu>
On Fri, Sep 21, 2007 at 02:23:46PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Pass the open file into the filesystem's *xattr() methods.
>
> This is needed to be able to correctly implement open-unlink-f*xattr
> semantics, without having to resort to "silly-renaming".
>
> Do this by adding a 'struct file *' parameter to i_op->*xattr(). For
> f... variants pass the open file pointer, in other cases pass NULL.
>
> This is safe from a compatibility standpoint, out-of-tree old stuff
> will continue to work, but will get a warning at compile time.
NACK, no more optional arguments, and passing file structs to xattr
stuff is silly. If your filesystem doesn't get open but unliked
right you will have to resort to silly renaming, I'm sorry.
Same argument applies to all pass file down patches in the series,
I won't comment on the separately.
next prev parent reply other threads:[~2007-09-21 12:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 12:23 [patch 0/5] VFS changes Miklos Szeredi
2007-09-21 12:23 ` [patch 1/5] VFS: pass open file to ->setattr() Miklos Szeredi
2007-09-21 12:23 ` [patch 2/5] VFS: pass open file to ->getattr() Miklos Szeredi
2007-09-21 18:37 ` Andreas Dilger
2007-09-21 21:07 ` Miklos Szeredi
2007-09-21 12:23 ` [patch 3/5] VFS: pass open file to ->xattr() Miklos Szeredi
2007-09-21 12:43 ` Christoph Hellwig [this message]
2007-09-21 13:00 ` Miklos Szeredi
2007-09-21 13:06 ` Christoph Hellwig
2007-09-21 13:16 ` Miklos Szeredi
2007-09-21 14:32 ` Trond Myklebust
2007-09-21 14:34 ` Christoph Hellwig
2007-09-21 14:59 ` Miklos Szeredi
2007-09-21 18:44 ` Andreas Dilger
2007-09-21 21:15 ` Miklos Szeredi
2007-09-21 14:43 ` Miklos Szeredi
2007-09-21 18:39 ` Andreas Dilger
2007-09-21 12:23 ` [patch 4/5] VFS: allow filesystems to implement atomic open+truncate Miklos Szeredi
2007-09-21 12:44 ` Christoph Hellwig
2007-09-21 13:01 ` Miklos Szeredi
2007-09-21 18:47 ` Andreas Dilger
2007-09-21 12:23 ` [patch 5/5] VFS: allow filesystem to override mknod capability checks Miklos Szeredi
2007-09-21 12:45 ` Christoph Hellwig
2007-09-21 13:10 ` Miklos Szeredi
2007-09-21 13:14 ` Christoph Hellwig
2007-09-21 13:18 ` Miklos Szeredi
2007-09-21 14:33 ` Christoph Hellwig
2007-09-21 14:48 ` Miklos Szeredi
2007-09-21 14:53 ` Christoph Hellwig
2007-09-21 15:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921124323.GA8088@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).