From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 3/5] VFS: pass open file to ->xattr() Date: Fri, 21 Sep 2007 13:43:23 +0100 Message-ID: <20070921124323.GA8088@infradead.org> References: <20070921122343.307289079@szeredi.hu> <20070921123333.247493758@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, hch@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:49389 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbXIUMnZ (ORCPT ); Fri, 21 Sep 2007 08:43:25 -0400 Content-Disposition: inline In-Reply-To: <20070921123333.247493758@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Sep 21, 2007 at 02:23:46PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Pass the open file into the filesystem's *xattr() methods. > > This is needed to be able to correctly implement open-unlink-f*xattr > semantics, without having to resort to "silly-renaming". > > Do this by adding a 'struct file *' parameter to i_op->*xattr(). For > f... variants pass the open file pointer, in other cases pass NULL. > > This is safe from a compatibility standpoint, out-of-tree old stuff > will continue to work, but will get a warning at compile time. NACK, no more optional arguments, and passing file structs to xattr stuff is silly. If your filesystem doesn't get open but unliked right you will have to resort to silly renaming, I'm sorry. Same argument applies to all pass file down patches in the series, I won't comment on the separately.