From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
hch@infradead.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/5] VFS: pass open file to ->xattr()
Date: Fri, 21 Sep 2007 15:34:27 +0100 [thread overview]
Message-ID: <20070921143427.GB14577@infradead.org> (raw)
In-Reply-To: <1190385151.6680.35.camel@heimdal.trondhjem.org>
On Fri, Sep 21, 2007 at 10:32:31AM -0400, Trond Myklebust wrote:
> On Fri, 2007-09-21 at 15:16 +0200, Miklos Szeredi wrote:
>
> > > ftruncate is a special case due to O_TRUNC.
> >
> > No, it's special, because it does not do permission checking, while
> > truncate() does.
>
> So why not just add file->f_op->ftruncate() and file->f_op->fstat()?
> Most filesystems can trivially redirect these to do_truncate() and their
> existing getattr() method. Those, like FUSE, that care can use the hook.
> In fact, I think that NFSv4 could also benefit from an ftruncate():
> currently we have to hunt around for an open file context for that
> particular case.
Havin the file for fruncate is fine and I'm planning to do something
along those lines. Having it for (f)stat is dumb because the operation
is in no way related to the open file descriptor.
next prev parent reply other threads:[~2007-09-21 14:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 12:23 [patch 0/5] VFS changes Miklos Szeredi
2007-09-21 12:23 ` [patch 1/5] VFS: pass open file to ->setattr() Miklos Szeredi
2007-09-21 12:23 ` [patch 2/5] VFS: pass open file to ->getattr() Miklos Szeredi
2007-09-21 18:37 ` Andreas Dilger
2007-09-21 21:07 ` Miklos Szeredi
2007-09-21 12:23 ` [patch 3/5] VFS: pass open file to ->xattr() Miklos Szeredi
2007-09-21 12:43 ` Christoph Hellwig
2007-09-21 13:00 ` Miklos Szeredi
2007-09-21 13:06 ` Christoph Hellwig
2007-09-21 13:16 ` Miklos Szeredi
2007-09-21 14:32 ` Trond Myklebust
2007-09-21 14:34 ` Christoph Hellwig [this message]
2007-09-21 14:59 ` Miklos Szeredi
2007-09-21 18:44 ` Andreas Dilger
2007-09-21 21:15 ` Miklos Szeredi
2007-09-21 14:43 ` Miklos Szeredi
2007-09-21 18:39 ` Andreas Dilger
2007-09-21 12:23 ` [patch 4/5] VFS: allow filesystems to implement atomic open+truncate Miklos Szeredi
2007-09-21 12:44 ` Christoph Hellwig
2007-09-21 13:01 ` Miklos Szeredi
2007-09-21 18:47 ` Andreas Dilger
2007-09-21 12:23 ` [patch 5/5] VFS: allow filesystem to override mknod capability checks Miklos Szeredi
2007-09-21 12:45 ` Christoph Hellwig
2007-09-21 13:10 ` Miklos Szeredi
2007-09-21 13:14 ` Christoph Hellwig
2007-09-21 13:18 ` Miklos Szeredi
2007-09-21 14:33 ` Christoph Hellwig
2007-09-21 14:48 ` Miklos Szeredi
2007-09-21 14:53 ` Christoph Hellwig
2007-09-21 15:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921143427.GB14577@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).