From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dilger Subject: Re: [patch 2/5] VFS: pass open file to ->getattr() Date: Fri, 21 Sep 2007 12:37:54 -0600 Message-ID: <20070921183754.GO32520@schatzie.adilger.int> References: <20070921122343.307289079@szeredi.hu> <20070921123331.655294226@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, hch@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from mail.clusterfs.com ([74.0.229.162]:51613 "EHLO mail.clusterfs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756676AbXIUSh3 (ORCPT ); Fri, 21 Sep 2007 14:37:29 -0400 Content-Disposition: inline In-Reply-To: <20070921123331.655294226@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sep 21, 2007 14:23 +0200, Miklos Szeredi wrote: > @@ -1212,7 +1212,8 @@ struct inode_operations { > - int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *); > + int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *, > + struct file *file); It's not much of an inode operation anymore if you need to pass a file to it... Since the attributes are really part of the inode and not the file, this seems like a bit of a hack. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.