From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: hch@infradead.org, trond.myklebust@fys.uio.no,
adilger@clusterfs.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/2] VFS: new fgetattr() file operation
Date: Mon, 24 Sep 2007 13:36:40 +0100 [thread overview]
Message-ID: <20070924123640.GA17409@infradead.org> (raw)
In-Reply-To: <E1IZmze-0003q9-00@dorka.pomaz.szeredi.hu>
On Mon, Sep 24, 2007 at 02:24:54PM +0200, Miklos Szeredi wrote:
> Thanks to everyone for the feedback. Here's two of the VFS patches
> reworked according to comments. I also plan to rework the setattr()
> patch accordingly and perhaps the xattr patch, altough that is the
> lowest priority.
>
> Christoph, are these OK with you in this form?
Not at all. Attribute operations like this have no business at all
looking at the struct file. Please fix your dreaded filesystem to
implement proper unix semantics intead, and if that means adding
silly rename support so be it.
next prev parent reply other threads:[~2007-09-24 12:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 12:24 [patch 1/2] VFS: new fgetattr() file operation Miklos Szeredi
2007-09-24 12:25 ` [patch 2/2] VFS: allow filesystem to override mknod capability checks Miklos Szeredi
2007-09-24 12:38 ` Christoph Hellwig
2007-09-28 2:40 ` Neil Brown
2007-10-01 18:06 ` Miklos Szeredi
2007-09-24 12:36 ` Christoph Hellwig [this message]
2007-09-24 12:48 ` [patch 1/2] VFS: new fgetattr() file operation Miklos Szeredi
2007-09-24 12:59 ` Matthew Wilcox
2007-09-24 13:06 ` Miklos Szeredi
2007-09-24 13:10 ` Christoph Hellwig
2007-09-24 13:18 ` Miklos Szeredi
2007-09-24 13:27 ` Christoph Hellwig
2007-09-24 13:38 ` Miklos Szeredi
2007-09-24 13:16 ` Matthew Wilcox
2007-09-24 13:21 ` Miklos Szeredi
2007-09-24 13:42 ` Alan Cox
2007-09-24 13:40 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924123640.GA17409@infradead.org \
--to=hch@infradead.org \
--cc=adilger@clusterfs.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).