From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting
Date: Wed, 26 Sep 2007 09:31:21 +0100
Message-ID: <20070926083121.GA8421@infradead.org>
References: <11907762042481-git-send-email-ezk@cs.sunysb.edu> <1190776207595-git-send-email-ezk@cs.sunysb.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk,
	hch@infradead.org
To: Erez Zadok <ezk@cs.sunysb.edu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:53592 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1749667AbXIZIb0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 26 Sep 2007 04:31:26 -0400
Content-Disposition: inline
In-Reply-To: <1190776207595-git-send-email-ezk@cs.sunysb.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote:
> Fixes bugs in number promotion/demotion computation, as per
> <http://lkml.org/lkml/2007/9/20/17>

It's better to use te page_offset helper as that avoids any confusion
on where to cast.