From: Andrew Morton <akpm@linux-foundation.org>
To: "Yan Zheng" <yanzheng@21cn.com>
Cc: linux-fsdevel@vger.kernel.org, Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd
Date: Wed, 26 Sep 2007 20:59:57 -0700 [thread overview]
Message-ID: <20070926205957.54f49465.akpm@linux-foundation.org> (raw)
In-Reply-To: <3d0408630709261930l730f5081n2391b236dd0efb71@mail.gmail.com>
On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <yanzheng@21cn.com> wrote:
> Hello,
>
> igrab return NULL on error.
>
> Signed-off-by: Yan Zheng<yanzheng@21cn.com>
> ---
> diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.c
> --- linux-2.6.23-rc8/fs/anon_inodes.c 2007-09-27 10:05:07.000000000 +0800
> +++ linux/fs/anon_inodes.c 2007-09-27 10:18:26.000000000 +0800
> @@ -87,8 +87,8 @@
> return -ENFILE;
>
> inode = igrab(anon_inode_inode);
> - if (IS_ERR(inode)) {
> - error = PTR_ERR(inode);
> + if (!inode) {
> + error = -ENOENT;
> goto err_put_filp;
> }
hm, does that code actually need to exist? igrab() is pretty expensive and
that fs is permanently mounted anyway...
next prev parent reply other threads:[~2007-09-27 4:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 2:30 [patch]anon_inodes.c: fix error check in anon_inode_getfd Yan Zheng
2007-09-27 3:59 ` Andrew Morton [this message]
2007-09-27 16:41 ` Davide Libenzi
2007-09-27 16:54 ` Davide Libenzi
2007-09-27 17:40 ` Andrew Morton
2007-09-27 17:56 ` Davide Libenzi
2007-09-27 18:20 ` Andrew Morton
2007-09-27 18:25 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926205957.54f49465.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).