From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Laurent Riffard <laurent.riffard@free.fr>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
reiserfs-devel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>
Subject: Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set
Date: Thu, 27 Sep 2007 21:26:07 +0100 [thread overview]
Message-ID: <20070927202607.GA3812@infradead.org> (raw)
In-Reply-To: <20070927124833.d2691813.akpm@linux-foundation.org>
On Thu, Sep 27, 2007 at 12:48:33PM -0700, Andrew Morton wrote:
> > __fput+0x124/0x1a9
> > fput+0x31/0x35
> > reiserfs_xattr_set+0x291/0x2b0 [reiserfs]
> > user_set+0x4c/0x57 [reiserfs]
> > reiserfs_setxattr+0x81/0xf1 [reiserfs]
> > vfs_setxattr+0x7d/0xfa
> > setxattr+0xb9/0xd1
> > sys_lsetxattr+0x4c/0x85
> > sysenter_past_esp+0x57/0x85
> >
> > EIP: mnt_drop_write+0x5b/0x9d
> >
>
> Hi, Dave!
This sure looks like a result of the reiserfs xattr code beeing
really sucky and passing a NULL vfsmount to dentry_open.
Dave will probably find a bandaid to work around this, but the
right fix is to stop using a file struct here entirely. If you
look at reiserfs_xattr_set it's not actually used at all except
for passing it to ->prepare_write and ->commit_write which then
don't use it at all. All that crap should be rewritten to just
pass the dentry around. Note that all this should not acquire
writer counts on the vfsmount - we have done this already
before calling into the xattr methods.
next prev parent reply other threads:[~2007-09-27 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070927022220.c76a7a6e.akpm@linux-foundation.org>
2007-09-27 19:18 ` 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set Laurent Riffard
2007-09-27 19:48 ` Andrew Morton
2007-09-27 20:05 ` Dave Hansen
2007-09-27 20:26 ` Christoph Hellwig [this message]
2007-09-27 20:53 ` [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations Dave Hansen
2007-09-27 21:04 ` Christoph Hellwig
2007-09-27 21:27 ` Dave Hansen
2007-09-27 21:51 ` Andrew Morton
2007-09-27 21:54 ` Andrew Morton
2007-09-27 22:02 ` Peter Zijlstra
2007-09-28 7:16 ` Christoph Hellwig
2007-09-28 7:29 ` [RFC][PATCH] stop abusing filp_open in reiserfs journal code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927202607.GA3812@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=laurent.riffard@free.fr \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).