From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Tso Subject: Re: [PATCH] fs: Correct SuS compliance for open of large file without options Date: Thu, 27 Sep 2007 22:21:18 -0400 Message-ID: <20070928022118.GF8688@thunk.org> References: <20070927154432.302ec5a7@the-village.bc.nu> <20070927150853.GA10154@kernel.dk> <20070927161912.2f08aff6@the-village.bc.nu> <20070927155902.GA6450@thunk.org> <20070927102343.1a113ccc.akpm@linux-foundation.org> <20070927175917.GB8339@kroah.com> <20070927183742.GA23734@thunk.org> <20070927213445.GA7857@kroah.com> <20070927231927.GE8688@thunk.org> <20070927232857.GA12049@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg KH , Andrew Morton , Alan Cox , Jens Axboe , Arjan van de Ven , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Matthew Wilcox Return-path: Received: from thunk.org ([69.25.196.29]:39910 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbXI1CWP (ORCPT ); Thu, 27 Sep 2007 22:22:15 -0400 Content-Disposition: inline In-Reply-To: <20070927232857.GA12049@parisc-linux.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Sep 27, 2007 at 05:28:57PM -0600, Matthew Wilcox wrote: > On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote: > > Would you accept a patch which causes the deprecated sysfs > > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is > > defined, via a boot-time parameter? > > How about a mount option? That way people can test without a reboot: > > mount -o remount,deprecated={yes,no} /sys It would be nice if that would be easy to make work, but the problem is that remounting /sysfs doesn't change the entries in the sysfs tree that have already been made in the tree. We could do something such as creating an sysfs_create_link_deprecated() call which created a kobject with a new flag indicating it's deprecated, so it could be filtered out dynamically when /sys is remounted, or when some file such as /sys/kernel/deprecated_sysfs_files has "0" or "1" written to it. The question is whether it's worth it, since we'd have to bloat the kobject structure by 4 bytes (it currently doesn't have a flags field from which we could borrow a bit), or whether it's OK just to make the user reboot. (I do agree it would be nicer if the user didn't have to reboot, but most of the time they will need to test the initrd and init scripts anyway. - Ted