From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <haveblue@us.ibm.com>,
hch@infradead.org, laurent.riffard@free.fr,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
reiserfs-devel@vger.kernel.org
Subject: Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations
Date: Fri, 28 Sep 2007 08:16:35 +0100 [thread overview]
Message-ID: <20070928071635.GA28841@infradead.org> (raw)
In-Reply-To: <20070927145125.1346901f.akpm@linux-foundation.org>
On Thu, Sep 27, 2007 at 02:51:25PM -0700, Andrew Morton wrote:
> That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over
> to ->write_begin() and ->write_end().
Yeah, I was looking at mainline.
> So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still
> failing on NFS, I think.
I'd rather avoid the paramater removal for now, that makes it less
entangle, and it's an unrelated cleanup anyway.
Btw, there's more abuse of this sort in reiserfs. Various other places
in xattr.c call dentry_open directly without the vfsmount aswell. And
handling of an external journal uses filp_open which is similarly stupid,
it should use open_bdev_excl like xfs or the generic code to open the
main filesystem blockdevice.
next prev parent reply other threads:[~2007-09-28 7:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070927022220.c76a7a6e.akpm@linux-foundation.org>
2007-09-27 19:18 ` 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set Laurent Riffard
2007-09-27 19:48 ` Andrew Morton
2007-09-27 20:05 ` Dave Hansen
2007-09-27 20:26 ` Christoph Hellwig
2007-09-27 20:53 ` [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations Dave Hansen
2007-09-27 21:04 ` Christoph Hellwig
2007-09-27 21:27 ` Dave Hansen
2007-09-27 21:51 ` Andrew Morton
2007-09-27 21:54 ` Andrew Morton
2007-09-27 22:02 ` Peter Zijlstra
2007-09-28 7:16 ` Christoph Hellwig [this message]
2007-09-28 7:29 ` [RFC][PATCH] stop abusing filp_open in reiserfs journal code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928071635.GA28841@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=laurent.riffard@free.fr \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).